Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Unrecognized symbol in correlation.cpp #1372

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

MeowZheng
Copy link
Collaborator

@MeowZheng MeowZheng commented Sep 25, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

There are some unrecognized symbols when compiling correlation op on Windows platform.

Modification

  1. Revise and to &&

BC-breaking (Optional)

No

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #1372 (bb7fe4c) into master (745aa73) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   68.57%   68.57%           
=======================================
  Files         164      164           
  Lines       10897    10897           
  Branches     1993     1993           
=======================================
  Hits         7473     7473           
  Misses       3032     3032           
  Partials      392      392           
Flag Coverage Δ
unittests 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745aa73...bb7fe4c. Read the comment docs.

@zhouzaida zhouzaida requested a review from ZwwWayne September 25, 2021 15:22
@ZwwWayne ZwwWayne merged commit a90b397 into open-mmlab:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants