-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decay to CyclicLrUpdater #1655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be nice if an image can be provided in the PR message to visualize the learning rate. Maybe you can refer to https://mmclassification.readthedocs.io/en/latest/tools/visualization.html#learning-rate-schedule-visualization. |
update docstring Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
We also need to add the two arguments mmcv/mmcv/runner/hooks/momentum_updater.py Line 226 in 86ed509
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR can be merged after resolving the comments.
Fix CyclicMomentum comment
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
I followed #1059 to modify and fixed the cyclic lr decay.
Modification
Fixed lr update error and unit test. The lr curve of config:
BC-breaking (Optional)
No.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: