Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bugs in DynamicScatter op #1748

Merged
merged 4 commits into from
Mar 7, 2022

Conversation

wHao-Wu
Copy link
Contributor

@wHao-Wu wHao-Wu commented Feb 25, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The unittest of mmdet3d fails after importing the DynamicScatter op from mmcv. I found that there exists an inconsistency of DynamicScatter op between mmdet3d and mmcv, which causes the failure of mmdet3d.

Modification

Recover the if statement.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@ZwwWayne
Copy link
Collaborator

Invite @zhanggefan to take a look at this PR

@ZwwWayne ZwwWayne requested a review from grimoire February 25, 2022 12:23
@wHao-Wu
Copy link
Contributor Author

wHao-Wu commented Mar 7, 2022

Successfully compile and test with the following versions on Linux

  • python37-pytorch1.3.0-cuda10.1
  • python37-pytorch1.5.0-cuda10.1
  • python36-pytorch1.8.0-cuda10.1

@ZwwWayne ZwwWayne merged commit 09b64a6 into open-mmlab:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants