Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix deform_conv inconsistent pybind #1781

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

teamwong111
Copy link
Contributor

@teamwong111 teamwong111 commented Mar 9, 2022

Motivation

resolves: #1080
Fix deformconv pybind.

Modification

As above.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida requested a review from grimoire March 11, 2022 01:43
@zhouzaida zhouzaida changed the title [Fix] Fix deformconv pybind [Fix] Fix deform_conv inconsistent pybind Mar 11, 2022
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida merged commit bdabdff into open-mmlab:master Mar 15, 2022
@teamwong111 teamwong111 deleted the fix-deformconv-pybind branch April 2, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using different paddings on w and h in deformable conv
3 participants