-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Fix collect_env on Windows #1789
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
65975d7
[fix] fix collect_env() on Windows
SuTanTank 746fecb
fix(utils): add back 'Cuda compilation tools' to nvcc info
SuTanTank 9d57970
feat(utils): find default ccompiler
SuTanTank 29692f9
fix(utils, test): parse cl.exe version instead of path
SuTanTank 72666bb
fix: code style
SuTanTank f29bb33
fix(tools): use distutils
SuTanTank 6363b09
[fix] collect_env() returns GCC or MSVC
SuTanTank 3ebdefb
[fix] unitest for collect_env()
SuTanTank ecd4e72
add comments
SuTanTank 433cbe7
test: add GCC to expected_keys
SuTanTank f59c2b3
fix: code style
SuTanTank 3fe1bfd
Update mmcv/utils/env.py
SuTanTank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be better if we can get the last line of
nvcc -V
which is consistent with the former version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Linux
On Windows (11.5)
Not sure what it looks like on other Windows machines. but the last line on Linux match with the second last line on Windows.
I will add 'Cuda compilation tools' to the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK~ thanks for your explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May leave comments in the code to explain.