Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support shallow copy for Config #1796

Merged
merged 10 commits into from
Mar 15, 2022

Conversation

imabackstabber
Copy link
Contributor

Motivation

since PR#1658 support a __deepcopy__ method for Config,__copy__ method should also be implemented.

Modification

Add __copy__ to Config

BC-breaking (Optional)

No

Use cases (Optional)

Shown in test_copy method in tests/test_utils/test_config.py

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mm-assistant mm-assistant bot added the size/XS label Mar 12, 2022
mmcv/utils/config.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@imabackstabber imabackstabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changed as suggested

mmcv/utils/config.py Outdated Show resolved Hide resolved
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida changed the title Support copy for Config [Feature] Support shallow copy for Config Mar 12, 2022
@zhouzaida zhouzaida requested review from ZwwWayne and HAOCHENYE March 13, 2022 01:23
@ZwwWayne ZwwWayne merged commit 1cd864d into open-mmlab:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants