Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support None in DictAction #1834

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

vakker
Copy link
Contributor

@vakker vakker commented Mar 24, 2022

Motivation

Resolves #1112

Modification

Adds --cfg-options key=none functionality.

BC-breaking (Optional)

None that I'm aware of.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mm-assistant mm-assistant bot added the size/XS label Mar 24, 2022
@CLAassistant
Copy link

CLAassistant commented Mar 24, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vakker
Copy link
Contributor Author

vakker commented Apr 1, 2022

@HAOCHENYE is there anything else needed for this PR?

mmcv/utils/config.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida requested a review from ZwwWayne April 6, 2022 03:49
@zhouzaida zhouzaida changed the title None parsing fixed for config [Enhancement] Support None in DictAction Apr 14, 2022
@zhouzaida zhouzaida merged commit b804477 into open-mmlab:master Apr 18, 2022
@OpenMMLab-Assistant003
Copy link

Hi @vakker!First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤ @vakker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support None in DictAction
6 participants