-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add rotated_feature_align cpu & onnxruntime implementation #1878
[Feature] Add rotated_feature_align cpu & onnxruntime implementation #1878
Conversation
@@ -0,0 +1,50 @@ | |||
#ifndef ONNXRUNTIME_ROTATED_FEATURE_ALIGN_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is worth to mension that all codes about deployment would be deprecated in the future. You are welcome to contribute the ONNX Runtime ops in MMDepoy.
Remove useless comment from mmcv/ops/csrc/pytorch/cpu/rotated_feature_align.cpp Replace ambiguous function name atomicAdd in mmcv/ops/csrc/pytorch/cpu/rotated_feature_align.cpp Simplify unit test with parameter in tests/test_ops/test_rotated_feature_align.py Use fma in interpolate in mmcv/ops/csrc/onnxruntime/cpu/rotated_feature_align.cpp mmcv/ops/csrc/pytorch/cpu/rotated_feature_align.cpp
Use fma in interpolate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please @zytx121 have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dear WilliamKyle, |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Add rotated_feature_align cpu & onnxruntime implementation
Modification
Please briefly describe what modification is made in this PR.
Add rotated_feature_align cpu & onnxruntime implementation
code modified from cuda implementation
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: