Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the output of scatter on MLU device #1881

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

Qiza-lyhm
Copy link
Contributor

Motivation

MMDP or MMDDP use origin scatter_gather to scatter Tensor to one or more device(s).
And the result of scatter_map should be a List of Tensor, each item is for one device.

However, the modified scatter_gather for MLUDP or MLUDDP only returns the pure Tensor.

It causes dimension errors when scatter this result again.

Modification

Change the output of scatter_map, thus the output is just the same size as GPU or CPU result.

BC-breaking (Optional)

No BC-breaking.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

To have the same shape of MLU copy and Scatter.forward, a 1-dim list has to be added.

Origin MMDP / MMDDP with this scatter_gather returns a list of tensor for each targets, and here MLU copy returns the same shape Tensor in a list of just one default target.
@zhouzaida zhouzaida changed the title [Fix]Fix the output of MLU copy to a Tensor list. [Fix] Fix the output of scatter on MLU device Apr 15, 2022
@zhouzaida zhouzaida merged commit 9527302 into open-mmlab:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants