[Fix]Fix is_module_wrapper #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
reviewed
Apr 21, 2022
zhouzaida
approved these changes
Apr 21, 2022
hhaAndroid
approved these changes
May 5, 2022
wangruohui
pushed a commit
to wangruohui/mmcv
that referenced
this pull request
Jun 11, 2022
* fix is_module_wrapper * test is_module_wrapper * fix code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to avoid scope collision with other codebases, DistributedDataParallelWrapper in mmrazor, mmpose, mmedit or some other codebases need to be registered to a separate registry whose parent is the MODULE_WRAPPERS registry in mmcv. Ref to this pr. When checking if a module is a module wrapper, we need to consider these child MODULE_WRAPPERS.
Modification
A Depth-First-Search is needed in
is_module_wrapper.