Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix type hint in file_client #1942

Merged
merged 9 commits into from
May 10, 2022
Merged

[Fix] Fix type hint in file_client #1942

merged 9 commits into from
May 10, 2022

Conversation

imabackstabber
Copy link
Contributor

Motivation

To fix some type hint in file_client

Modification

  1. Add mypy in precommit.yaml to check type hint
  2. Add type hint in file_client.py,also add some type hint in related file imported by fle_client.py

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida requested review from HAOCHENYE and teamwong111 May 9, 2022 07:47
zhouzaida
zhouzaida reviewed May 9, 2022
View reviewed changes
mmcv/tensorrt/__init__.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida changed the title [fix]:fix type hint in file_client [Fix] Fix type hint in file_client May 10, 2022
@zhouzaida zhouzaida merged commit a848ecf into open-mmlab:master May 10, 2022
@zhouzaida zhouzaida mentioned this pull request May 11, 2022
Closed
wangruohui pushed a commit to wangruohui/mmcv that referenced this pull request Jun 11, 2022
@imabackstabber
[Fix] Fix type hint in file_client (open-mmlab#1942)
d7a32ed 
* [fix]:fix type hint in file_client and mmcv

* [fix]:fix type hint in tests files

* [fix]:fix type hint in tests files

* [fix]:fix pre-commit.yaml to igore test for mypy

* [fix]:fix pre-commit.yaml to igore test for mypy

* [fix]:fix precommit.yml

* [fix]:fix precommit.yml

* Update __init__.py

delete unused type-ignore comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@teamwong111 teamwong111 teamwong111 approved these changes

@HAOCHENYE HAOCHENYE Awaiting requested review from HAOCHENYE

Assignees

@teamwong111 teamwong111

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imabackstabber @teamwong111 @zhouzaida