[Enhancement] Add type annoations for mmcv/visualization/image #1946
Conversation
|
|
|
Please update your branch by merging mmcv master branch. |
…ev_type_hints I added Type Hints in mmcv_visualization_image.py
zhouzaida
changed the title
zhouzaida
changed the title
…mmlab#1946) * dev_1st_mmcv_visual_image_py * dev_3rd_mmcv_visual_image_py * dev_4th_mmcv_visual_image_py * dev_5th_mmcv_visual_image_py * dev_6th_mmcv_visual_image_py * dev_7th_mmcv_visual_image_py * dev_8th_mmcv_visual_image_py * dev_9th_mmcv_visual_image_py * minor fix * fix isort Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
|
Hi @sundongwei ！First of all, we want to express our gratitude for your significant PR in the mmcv project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG If you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：） |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
I wanna become a contributor for MMCV, so I try to PR some easy tasks for a practice.
Modification
I added some Type Hints in image.py which path is "mmcv/mmcv/visualization".
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: