Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for runner/builder #1985

Merged

Conversation

ytzhao
Copy link
Contributor

@ytzhao ytzhao commented May 25, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add type hints for runner/builder

Modification

  • Update mmcv/runner/builder.py

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented May 25, 2022

CLA assistant check
All committers have signed the CLA.

@ytzhao ytzhao force-pushed the ytzhao/type_hints_runner_builder branch from 206f04c to 336f0f3 Compare May 25, 2022 15:01
@zhouzaida
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @ytzhao , thanks for your contribution. Please sign the CLA before we merge this PR.

@ytzhao
Copy link
Contributor Author

ytzhao commented May 26, 2022

Hi @zhouzaida, already done with the CLA ;-)

@zhouzaida
Copy link
Collaborator

Hi, you can merge the upstream master to fix the CI with the following steps.

git remote add open-mmlab git@github.com:open-mmlab/mmcv.git
git pull open-mmlab master
git push origin ytzhao/type_hints_runner_builder

@ytzhao ytzhao force-pushed the ytzhao/type_hints_runner_builder branch from 336f0f3 to 6430cef Compare May 26, 2022 12:38
@ytzhao ytzhao changed the title [Enhancement] Add type hints for runner/builder Add type hints for runner/builder May 26, 2022
@zhouzaida zhouzaida merged commit 84a544f into open-mmlab:master May 27, 2022
@ytzhao ytzhao deleted the ytzhao/type_hints_runner_builder branch May 27, 2022 02:45
wangruohui pushed a commit to wangruohui/mmcv that referenced this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants