Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add type hint in lr_updater.py. #1988

Merged
merged 3 commits into from
May 27, 2022

Conversation

WINDSKY45
Copy link
Contributor

Motivation

To get gift.

Modification

Add type hint in lr_updater.py.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

Sorry, something went wrong.

@CLAassistant
Copy link

CLAassistant commented May 25, 2022

CLA assistant check
All committers have signed the CLA.

@WINDSKY45
Copy link
Contributor Author

The CI failed but I don not know how to fix it. @zhouzaida

@zhouzaida
Copy link
Collaborator

The CI failed but I don not know how to fix it. @zhouzaida

Hi, you can use the following steps to update your branch which will fix the CI.

git remote add open-mmlab git@github.com:open-mmlab/mmcv.git
git pull open-mmlab master
git push origin typehint

@zhouzaida zhouzaida merged commit 335199d into open-mmlab:master May 27, 2022
wangruohui pushed a commit to wangruohui/mmcv that referenced this pull request Jun 11, 2022
* [Enhance] Add type hint in `lr_updater.py`.

* Fix circle import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants