[Enhance] Add type hint in focal_loss.py.
#1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
reviewed
May 26, 2022
zhouzaida
reviewed
May 28, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
WINDSKY45
added a commit
to WINDSKY45/mmcv
that referenced
this pull request
May 30, 2022
`fused_bias_leakyrelu.py`, 'gather_points.py`, `group_points.py`. There is no need to add type hints in `furthest_point_sample.py` and `info.py`. As for `focal_loss.py`, please see open-mmlab#1994.
7 tasks
WINDSKY45
added a commit
to WINDSKY45/mmcv
that referenced
this pull request
May 31, 2022
`fused_bias_leakyrelu.py`, 'gather_points.py`, `group_points.py`. There is no need to add type hints in `furthest_point_sample.py` and `info.py`. As for `focal_loss.py`, please see open-mmlab#1994.
WINDSKY45
force-pushed
the
typehint-focalloss
branch
from
52111dc to
a23c1bb
Compare
teamwong111
approved these changes
Jun 1, 2022
zhouzaida
reviewed
Jun 1, 2022
zhouzaida
reviewed
Jun 1, 2022
zhouzaida
reviewed
Jun 1, 2022
zhouzaida
reviewed
Jun 2, 2022
zhouzaida
approved these changes
Jun 2, 2022
zhouzaida
reviewed
Jun 2, 2022
HAOCHENYE
approved these changes
Jun 2, 2022
zhouzaida
added a commit
that referenced
this pull request
Jun 20, 2022
* [Enhance] Add type hints in /ops: `fused_bias_leakyrelu.py`, 'gather_points.py`, `group_points.py`. There is no need to add type hints in `furthest_point_sample.py` and `info.py`. As for `focal_loss.py`, please see #1994. * Modidied the default value of a variable. * [Enhance] Add type hints in: `knn.py`, `masked_conv.py`, `merge_cells.py`, `min_area_polygons.py`, `modulated_deform_conv.py`, multi_scale_deform_attn.py`. * Fix typehint. * Fixed typehint. * remove type hints of symbolic * add no_type_check to ignore mypy check for method Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To get gift.
Modification
Add type hint in focal_loss.py.
Checklist
Before PR:
After PR: