Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for mmcv/ops #1995

Merged
merged 27 commits into from
Jun 20, 2022
Merged

Conversation

triple-Mu
Copy link
Contributor

@triple-Mu triple-Mu commented May 26, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add type hints for mmcv/ops

Modification

mmcv/ops

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida mentioned this pull request May 28, 2022
7 tasks
@zhouzaida
Copy link
Collaborator

Hi @triple-Mu , lint failed.

@zhouzaida
Copy link
Collaborator

Need to add type hints for return values.

mmcv/ops/roi_align.py Outdated Show resolved Hide resolved
mmcv/ops/roi_pool.py Outdated Show resolved Hide resolved
mmcv/ops/roi_pool.py Outdated Show resolved Hide resolved
mmcv/ops/sync_bn.py Outdated Show resolved Hide resolved
triple-Mu and others added 2 commits June 17, 2022 20:49
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
mmcv/ops/roi_align.py Outdated Show resolved Hide resolved
mmcv/ops/roi_pool.py Outdated Show resolved Hide resolved
mmcv/ops/sync_bn.py Outdated Show resolved Hide resolved
mmcv/ops/psa_mask.py Outdated Show resolved Hide resolved
mmcv/ops/upfirdn2d.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida changed the title Add typehint in mmcv/ops/* Add type hints for mmcv/ops Jun 18, 2022
@zhouzaida zhouzaida merged commit 2d3e42f into open-mmlab:master Jun 20, 2022
@triple-Mu triple-Mu deleted the tripleMu-typehint1 branch July 1, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants