-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints for runner/base_runner #2003
Add type hints for runner/base_runner #2003
Conversation
Hi~ Is there any progress? |
2820e7d
to
0d0fee6
Compare
Hi @HAOCHENYE already updated, pls take a review, thanks ;-) |
Hi, thanks for your contributions. We can also add type hints for epoch_based_runner.py and iter_based_runner.py at this PR. |
Hi~ @ytzhao, Is there any progress? |
c74b6c2
to
ff9af0b
Compare
@ytzhao Hi~ The lint seems failed. |
ff9af0b
to
9cd32dd
Compare
@HAOCHENYE Hi, the unit_tests job is in progress for a long time, it started 2d ish ago, weird. |
Hi, that is ok. That unit test needs to be triggered by us manually. |
9cd32dd
to
e778a0b
Compare
@zhouzaida @HAOCHENYE Hi, please check the latest updated, thanks |
Okay |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add type hints for runner/base_runner.
Modification
BC-breaking (Optional)
No
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: