Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints in mmcv/ops/active_rotated_filter.py #2017

Merged
merged 2 commits into from
May 28, 2022

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 28, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add type hints in mmcv/ops/active_rotated_filter.py

Modification

Add type hints

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@HAOCHENYE HAOCHENYE self-requested a review May 28, 2022 11:50
@zhouzaida zhouzaida changed the title add typehints in ops-active-rotated-filter Add type hints in mmcv/ops/active_rotated_filter.py May 28, 2022
@zhouzaida zhouzaida merged commit 1577f40 into open-mmlab:master May 28, 2022
@shawnh2 shawnh2 deleted the th-ops1-arf branch May 28, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants