[Fix] make iou3d.boxes_iou3d actually calculate 3D IoU #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tai-Wang
reviewed
May 30, 2022
|
May refine the PR title to make this fix more clear |
|
Other modifications LGTM. |
grimoire
reviewed
May 30, 2022
filaPro
changed the title
Tai-Wang
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix a bug introduced in #1902. Actually
boxes_iou3dwas calculatingbev iou. Now it is fixed. Alsoboxes_overlap_bevis now a public function and can be used not only to calculate3d ioubut also3d iofinmmdetection3d.Modification
Fix
boxes_iou3din python and cuda. Addboxes_overlap_bevand corresponding tests.BC-breaking (Optional)
No. Actually
boxes_iou3dwas not used inmmdetection3dand now it is just fixes.May by @ZwwWayne or @Tai-Wang can have a look about
mmdetection3dconnection.