-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Add type ints in these files: #2020
Merged
Merged
+144
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
reviewed
May 28, 2022
HAOCHENYE
reviewed
May 28, 2022
HAOCHENYE
reviewed
May 28, 2022
HAOCHENYE
reviewed
May 28, 2022
HAOCHENYE
reviewed
May 28, 2022
HAOCHENYE
reviewed
May 28, 2022
HAOCHENYE
reviewed
May 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add return Type Hints for the __init__
method. If it is added, it should also ensure that the format is uniform
I have fixed them. |
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 29, 2022
zhouzaida
reviewed
May 30, 2022
zhouzaida
reviewed
May 30, 2022
zhouzaida
reviewed
May 30, 2022
zhouzaida
reviewed
May 30, 2022
Please add type hints for following methods:
|
Hi, please resolve conflicts. |
zhouzaida
reviewed
May 30, 2022
'base_module.py', 'checkpoint.py', 'default_constructor.py', 'dist_utils.py', 'fp16_utils.py', 'log_buffer.py', 'priority.py'.
Removed the return type of __init__ funcs.
WINDSKY45
force-pushed
the
typehint-runner
branch
from
May 31, 2022 10:04
0f4465b
to
bb43755
Compare
zhouzaida
approved these changes
May 31, 2022
teamwong111
approved these changes
Jun 1, 2022
zhouzaida
reviewed
Jun 2, 2022
zhouzaida
reviewed
Jun 2, 2022
zhouzaida
reviewed
Jun 2, 2022
zhouzaida
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification
Add type hints in these files:
'base_module.py', 'checkpoint.py',
'default_constructor.py',
'dist_utils.py', 'fp16_utils.py',
'log_buffer.py', 'priority.py'.
Checklist
Before PR:
After PR: