Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support PSAMask with cambricon MLU backend #2024

Merged
merged 7 commits into from
Jun 8, 2022
Merged

[Feature] Support PSAMask with cambricon MLU backend #2024

merged 7 commits into from
Jun 8, 2022

Conversation

zcyKTH
Copy link
Contributor

@zcyKTH zcyKTH commented May 29, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation of the PR is to support running PSAMask with Cambricon MLU backend.

It includes three parts:

Add psamask_mlu_kernel.mlu src code as mlu kernel.
Add psamask_mlu.cpp to support launching kernel in pytorch.
Refactor test_psa_mask.py to support testing psamask with MLU backend.

Modification

MLU src code
Add MLU src code of psamask in directory mmcv/ops/csrc/common/mlu/psamask_mlu_kernel.mlu.
Pytorch adaptation
Adapt psamask for pytorch in mmcv/ops/csrc/pytorch/mlu/psamask_mlu.cpp.
Unit test
Surpport test psamask with various backends in tests/test_ops/test_psa_mask.py.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@teamwong111 teamwong111 requested a review from grimoire June 1, 2022 09:45
@grimoire
Copy link
Member

grimoire commented Jun 2, 2022

Compile failed with log:

./mmcv/ops/csrc/common/mlu/psamask_mlu_kernel.mlu:117:28: error: no matching function for call to 'max'
        const int hstart = std::max(0, half_h_mask - h_abs);
                           ^~~~~~~~

cncc version :

cncc 3.6.4 clang version 11.0.0

@zcyKTH
Copy link
Contributor Author

zcyKTH commented Jun 8, 2022

Compile failed with log:

./mmcv/ops/csrc/common/mlu/psamask_mlu_kernel.mlu:117:28: error: no matching function for call to 'max'
        const int hstart = std::max(0, half_h_mask - h_abs);
                           ^~~~~~~~

cncc version :

cncc 3.6.4 clang version 11.0.0

I have replaced std::min/max with conditional operations, which is similar to #2033.

@zhouzaida zhouzaida merged commit 5601427 into open-mmlab:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants