-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support RoiPool with Cambricon MLU backend #2073
Conversation
There are some warning:
Is it expected? |
Which version of CNToolkit or CNAS? |
@zcyKTH How can I check the version? |
Try to check |
Neuware Version 2.6.4 The warning appears when compiling the op. The build finished with no error and the test also passed. |
Yep. Just ignore these oversensitive warnings and they have been removed in future Neuware Version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The motivation of the PR is to support running RoiPool with Cambricon MLU backend.
It includes three parts:
roi_pool_mlu_kernel.mlu
src code as MLU kernel.roi_pool_mlu.cpp
to support launching kernel in PyTorch.test_roi_pool.py
to support testing RoiPool with MLU backend.Modification
Add MLU src code of RoiPool in directory
mmcv/ops/csrc/common/mlu/roi_pool_mlu_kernel.mlu
.Adapt RoiPool for PyTorch in
mmcv/ops/csrc/pytorch/mlu/roi_pool_mlu.cpp
.Add data conversion functions between fp32 and int32 in
mmcv/ops/csrc/common/mlu/common_mlu_helper.hpp
.Surpport test RoiPool with various backends in
tests/test_ops/test_roi_pool.py
.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: