[Feature] Support CARAFE with Cambricon MLU backend #2087
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The motivation of the PR is to support running CARAFE with Cambricon MLU backend.
It includes three parts:
Add
carafe_mlu_kernel.mlu
src code as MLU kernel.Add
carafe_mlu.cpp
to support launching kernel in PyTorch.Refactor
test_carafe.py
to support allclose check.Modification
MLU src code
Add MLU src code of CARAFE in directory
mmcv/ops/csrc/common/mlu/carafe_mlu_kernel.mlu
.PyTorch adaptation
Adapt CARAFE for PyTorch in
mmcv/ops/csrc/pytorch/mlu/carefe_mlu.cpp
.Common functions
Add IO functions with 2D/3D pattern in
mmcv/ops/csrc/common/mlu/common_mlu_helper.hpp
.Unit test
Add baseline in
tests/data/for_carafe
and support test CARAFE with various backends intests/test_ops/test_carafe.py
.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: