Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support different border modes in imrotate #2141

Merged
merged 9 commits into from
Aug 17, 2022

Conversation

JingweiZhang12
Copy link
Contributor

@JingweiZhang12 JingweiZhang12 commented Jul 22, 2022

Support different border modes in mmcv.imrotate

Motivation

Make the args borderMode in original API cv2.warpAffine in opencv exposed in the inferface of mmcv.imrorate() so that users can switch different border modes freely.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

mmcv/image/geometric.py Outdated Show resolved Hide resolved
mmcv/image/geometric.py Outdated Show resolved Hide resolved
mmcv/image/geometric.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida requested a review from GT9505 August 16, 2022 07:42
@zhouzaida zhouzaida merged commit b9bdfeb into open-mmlab:master Aug 17, 2022
zhouzaida pushed a commit that referenced this pull request Aug 18, 2022
* support different border_mode in imrotate

* fix docstring

* small fix

* reorder the border_mode arg in imrotate

* fix lint

* polish docstring

* polish docstring
zhouzaida pushed a commit that referenced this pull request Aug 18, 2022
* support different border_mode in imrotate

* fix docstring

* small fix

* reorder the border_mode arg in imrotate

* fix lint

* polish docstring

* polish docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants