-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Support different border modes in imrotate #2141
Merged
zhouzaida
merged 9 commits into
open-mmlab:master
from
JingweiZhang12:enhance_imgrorate
Aug 17, 2022
Merged
[Enhance] Support different border modes in imrotate #2141
zhouzaida
merged 9 commits into
open-mmlab:master
from
JingweiZhang12:enhance_imgrorate
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
reviewed
Aug 14, 2022
zhouzaida
reviewed
Aug 16, 2022
zhouzaida
reviewed
Aug 16, 2022
zhouzaida
approved these changes
Aug 16, 2022
GT9505
approved these changes
Aug 17, 2022
zhouzaida
pushed a commit
that referenced
this pull request
Aug 18, 2022
* support different border_mode in imrotate * fix docstring * small fix * reorder the border_mode arg in imrotate * fix lint * polish docstring * polish docstring
zhouzaida
pushed a commit
that referenced
this pull request
Aug 18, 2022
* support different border_mode in imrotate * fix docstring * small fix * reorder the border_mode arg in imrotate * fix lint * polish docstring * polish docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support different border modes in
mmcv.imrotate
Motivation
Make the args
borderMode
in original APIcv2.warpAffine
in opencv exposed in the inferface ofmmcv.imrorate()
so that users can switch different border modes freely.Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: