Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DvcliveLoggerHook: use by_epoch for determining when to log. #2149

Merged
merged 3 commits into from
May 22, 2023
Merged

DvcliveLoggerHook: use by_epoch for determining when to log. #2149

merged 3 commits into from
May 22, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jul 26, 2022

@zhouzaida zhouzaida requested a review from HAOCHENYE July 26, 2022 13:54
@zhouzaida
Copy link
Collaborator

Hi @daavoo , thanks for your contributions. The CI failed.

@daavoo @zhouzaida
Update mmcv/runner/hooks/logger/dvclive.py
c9a1629 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@daavoo daavoo force-pushed the dvclive-by-epoch branch from c31ccb3 to c9a1629 Compare July 26, 2022 15:21
HAOCHENYE
HAOCHENYE reviewed Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DvcliveLoggerHook will only log the average loss of the last several iterations of each epoch. Could we log the average loss of the whole epoch?

@rick-van-veen
Copy link

Would love to have this feature available :-)

@shcheklein
Copy link

@daavoo hey, qq - what is the status of this?

@zhouzaida zhouzaida changed the base branch from master to 1.x May 22, 2023 06:44
@zhouzaida zhouzaida merged commit 445910e into open-mmlab:1.x May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@HAOCHENYE HAOCHENYE HAOCHENYE approved these changes

Assignees

@ice-tong ice-tong

Labels
Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour by_epoch DvcliveLoggerHook/AnyLogger DvcliveLoggerHook by_epoch not working
6 participants
@daavoo @zhouzaida @rick-van-veen @shcheklein @HAOCHENYE @ice-tong