Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix test_onnx tests #2155

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[Fix] Fix test_onnx tests #2155

merged 1 commit into from
Jul 29, 2022

Conversation

xcnick
Copy link
Contributor

@xcnick xcnick commented Jul 29, 2022 •
edited by zhouzaida
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Since ONNXRuntime 1.9, the providers parameter of InferenceSession are required explicitly. So add this parameter when initializing the InferenceSession object.

Modification

tests/test_ops/test_onnx.py

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@xcnick xcnick changed the title fix test_onnx tests [Fix] fix test_onnx tests Jul 29, 2022
@zhouzaida zhouzaida requested a review from grimoire July 29, 2022 04:45
grimoire
grimoire approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida changed the title [Fix] fix test_onnx tests [Fix] Fix test_onnx tests Jul 29, 2022
@zhouzaida zhouzaida merged commit 4558bfb into open-mmlab:master Jul 29, 2022
zhouzaida pushed a commit to zhouzaida/mmcv that referenced this pull request Aug 1, 2022
@xcnick @zhouzaida
[Fix] Fix onnx unit tests (open-mmlab#2155)
b75cb48
zhouzaida added a commit that referenced this pull request Aug 3, 2022
@zhouzaida @xcnick @JingweiZhang12
Pick commits from master (#2164)
0b4285d 
* [Docs] Add swith_language.md in docs (#2160)

* [Fix] Fix onnx unit tests (#2155)

* [Docs] Limit extension versions (#2144)

* Support PrRoIPool operation

* Add MPS bbox overlap

* Add .pre-commit-config-zh-cn.yaml (#2135)

Co-authored-by: xcnick <xcnick0412@gmail.com>
Co-authored-by: Jingwei Zhang <zjw18@mails.tsinghua.edu.cn>
Co-authored-by: q.yao <yaoqian@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grimoire grimoire grimoire approved these changes

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees

@ice-tong ice-tong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xcnick @CLAassistant @grimoire @zhouzaida @ice-tong