Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix init weights #2158

Merged
merged 3 commits into from
Aug 1, 2022
Merged

[Fix] Fix init weights #2158

merged 3 commits into from
Aug 1, 2022

Conversation

chhluo
Copy link
Contributor

@chhluo chhluo commented Jul 29, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

[Please describe the motivation of this PR and the goal you want to achieve through this PR.](

thetas = torch.arange(

thetas is created on cpu.

An error occurs if model.init_weights() is executed after model.to(device).)

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@chhluo chhluo requested a review from zhouzaida July 29, 2022 08:18
@zhouzaida zhouzaida linked an issue Jul 30, 2022 that may be closed by this pull request
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida merged commit 47a61c3 into dev-2.x Aug 1, 2022
@zhouzaida zhouzaida deleted the chhluo/fix_init_weights branch August 1, 2022 06:12
zhouzaida added a commit to zhouzaida/mmcv that referenced this pull request Aug 1, 2022
)

* fix tensors on different device

* fix lint

* Update mmcv/ops/multi_scale_deform_attn.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
zhouzaida added a commit to zhouzaida/mmcv that referenced this pull request Aug 1, 2022
)

* fix tensors on different device

* fix lint

* Update mmcv/ops/multi_scale_deform_attn.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
zhouzaida added a commit that referenced this pull request Aug 3, 2022
* fix tensors on different device

* fix lint

* Update mmcv/ops/multi_scale_deform_attn.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe a bug about multi_scale_deform_attn
3 participants