Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fileio from mmcv and use mmengine.fileio instead #2179

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Aug 5, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Remove fileio from mmcv and use mmengine.fileio instead

Modification

  • Remove mmcv/fileio
  • Remove docs/en/understand_mmcv/io.md and docs/zh_cn/understand_mmcv/io.md
  • Replace fileio interfaces

BC-breaking (Optional)

yes

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@ZwwWayne ZwwWayne added this to the 2.0.0rc1 milestone Aug 15, 2022
@ZwwWayne ZwwWayne requested review from HAOCHENYE and ZwwWayne August 15, 2022 02:42
@ZwwWayne ZwwWayne added the P1 label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants