Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add argument params to MlflowLoggerHook #2193

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

eivtho
Copy link

@eivtho eivtho commented Aug 12, 2022

Recreated #2188 since I did not use a feature branch.

Motivation

I want to log (hyper)parametrers in MLFLow to be able to compare them between runs.

Modification

Adds the argument "params" to MlflowLoggerHook. This works in the same way as the existing argument "tags" in that it runs mlflow.log_params() in before_run().

BC-breaking (Optional)

No.

Use cases (Optional)

See motivation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@eivtho eivtho marked this pull request as ready for review August 12, 2022 10:07
@zhouzaida zhouzaida requested a review from HAOCHENYE August 12, 2022 17:26
@zhouzaida zhouzaida changed the title add argument params to MlflowLoggerHook [Feature] Add argument params to MlflowLoggerHook Aug 16, 2022
@zhouzaida zhouzaida merged commit de9e625 into open-mmlab:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants