Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix the example error in registry.md #2243

Merged
merged 2 commits into from
Sep 2, 2022
Merged

[Docs] Fix the example error in registry.md #2243

merged 2 commits into from
Sep 2, 2022

Conversation

Hoantrbl
Copy link

@Hoantrbl Hoantrbl commented Sep 1, 2022

def converter2(a, b):
return Converter1(a, b)

the lack of colon(:)  

# 使用注册器管理模块
@CONVERTERS.register_module()
def converter2(a, b):
    return Converter1(a, b)
@CLAassistant
Copy link

CLAassistant commented Sep 1, 2022

CLA assistant check
All committers have signed the CLA.

@zhouzaida
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @PungTeng , thanks for you contribution. Before we merge this PR, you need to sign the CLA.

@Hoantrbl
Copy link
Author

Hoantrbl commented Sep 2, 2022

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @PungTeng , thanks for you contribution. Before we merge this PR, you need to sign the CLA.

Okay,I have agreed to the CLA for open-mmlab/mmcv. Thanks!

@zhouzaida zhouzaida changed the title the lack of the colon(:) [Docs] Fix the example error in registry.md Sep 2, 2022
@zhouzaida zhouzaida merged commit 7f09a98 into open-mmlab:master Sep 2, 2022
@OpenMMLab-Assistant005
Copy link

Hi @PungTeng !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants