Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre commit hooks #2321

Merged
merged 8 commits into from
Oct 8, 2022

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Oct 7, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Related PR: #2317

The motivation to upgrade some versions of pre-commit hooks to latest is that importlib-metadata v5.0.0 which removed deprecated endpoint breaks the flake8. More details at https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean/73932581#73932581.

Modification

Upgrade some versions of pre-commit hooks.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida marked this pull request as draft October 7, 2022 06:47
@zhouzaida zhouzaida marked this pull request as ready for review October 7, 2022 13:02
@zhouzaida zhouzaida marked this pull request as draft October 7, 2022 13:09
@zhouzaida zhouzaida marked this pull request as ready for review October 7, 2022 13:30
@zhouzaida zhouzaida requested a review from HAOCHENYE October 8, 2022 02:57
@zhouzaida zhouzaida merged commit b6a7fd9 into open-mmlab:master Oct 8, 2022
@zhouzaida zhouzaida deleted the upgrade-pre-commit-hooks branch October 8, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants