Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add BezierAlign CUDA op #2393

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

Harold-lkk
Copy link
Collaborator

Motivation

Bezier Align for ABCNet

@Harold-lkk Harold-lkk changed the title [WIP] bezier align [Feature] bezier align Dec 6, 2022
@Harold-lkk Harold-lkk changed the title [Feature] bezier align [Features] bezier align Dec 6, 2022
@zhouzaida zhouzaida requested a review from grimoire December 13, 2022 03:16
@grimoire
Copy link
Member

Please update docs in docs/en/understand_mmcv/ops.md and and docs/zh_cn/understand_mmcv/ops.md, Add unit test in tests/test_ops/

mmcv/ops/bezier_align.py Outdated Show resolved Hide resolved
mmcv/ops/bezier_align.py Outdated Show resolved Hide resolved
@Harold-lkk Harold-lkk requested a review from grimoire January 3, 2023 12:54
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 66.34% // Head: 66.39% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (81f4c00) compared to base (78fdf17).
Patch coverage: 74.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2393      +/-   ##
==========================================
+ Coverage   66.34%   66.39%   +0.04%     
==========================================
  Files         120      121       +1     
  Lines        7746     7793      +47     
  Branches     1074     1074              
==========================================
+ Hits         5139     5174      +35     
- Misses       2438     2450      +12     
  Partials      169      169              
Flag Coverage Δ
unittests 66.39% <74.46%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/bezier_align.py 73.91% <73.91%> (ø)
mmcv/ops/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Harold-lkk Harold-lkk requested a review from grimoire January 6, 2023 06:31
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzaida zhouzaida changed the title [Features] bezier align [Features] Add BezierAlign CUDA op Jan 10, 2023
@zhouzaida zhouzaida changed the title [Features] Add BezierAlign CUDA op [Feature] Add BezierAlign CUDA op Jan 10, 2023
@Harold-lkk Harold-lkk requested a review from zhouzaida January 10, 2023 03:30
@zhouzaida zhouzaida merged commit 7156604 into open-mmlab:2.x Jan 10, 2023
tyomj pushed a commit to tyomj/mmcv that referenced this pull request May 8, 2023
* bezier align

* add ut

* fix comment

* updata ut

* fix link and comment

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants