Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support DCNv1 on Ascend device #2480

Merged
merged 9 commits into from
Jan 6, 2023

Conversation

MiniTIckW
Copy link

@MiniTIckW MiniTIckW commented Dec 10, 2022

Motivation

This PR contains a npu-adapter of mmcv ops, deform_conv. It leads to that this op are avaliable on ascend-npu device.

Modification

We fix some bug of the ascend_npu adapter of modulated_deform_conv, and modify deform_conv which could be conveniently adapted by some torch_npu ops.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2022

CLA assistant check
All committers have signed the CLA.

update lately npu modification--DCNv1
mmcv/ops/deform_conv.py Outdated Show resolved Hide resolved
mmcv/ops/deform_conv.py Outdated Show resolved Hide resolved
@MiniTIckW MiniTIckW requested a review from grimoire December 21, 2022 06:25
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckirchhoff2021
Copy link
Collaborator

lgtm

@zhouzaida zhouzaida added the NPU Ascend label Dec 28, 2022
@zhouzaida zhouzaida changed the title update lately npu modification--DCNv1 [Feature] Support DCNv1 on Ascend device Jan 6, 2023
@zhouzaida zhouzaida merged commit f76de90 into open-mmlab:master Jan 6, 2023
defei-coder pushed a commit to defei-coder/mmcv that referenced this pull request Jan 30, 2023
* update lately npu modification--DCNv1

update lately npu modification--DCNv1

* update lately npu modification--DCNv1

* update lately npu modification--DCNv1

* update lately npu modification--DCNv1

* update lately npu modification--DCNv1

* update lately npu modification--DCNv1

* check code

* Add ops to EN/ZH documents
@OpenMMLab-Assistant001
Copy link

Hi @MiniTIckW !First of all, we want to express our gratitude for your significant PR in the MMCV project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPU Ascend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants