Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make build_xxx_layer allow accepting a class type #2782

Merged
merged 10 commits into from
May 11, 2023

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Make build_xxx_layer accept cfg dict with a class type

In MMEngine, build_from_cfg allows accepting a read class type like this:

from mmengine.hooks import LoggerHook

cfg = dict(type=LoggerHook)
hook = build_from_cfg(cfg)

However, build_xxx_layer in MMCV does not allow accepting a class type:

from mmcv.cnn import build_conv_layer
from torch.nn import Conv2d

cfg = dict(type=Conv2d, ...)
layer = build_conv_layer(cfg)  # will raise an error

This PR makes build_xxx_layer can build layer from the class type.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@HAOCHENYE HAOCHENYE force-pushed the support_build_from_type branch from 3b75f07 to 895319a Compare May 11, 2023 07:21
@zhouzaida zhouzaida merged commit 59c1418 into open-mmlab:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants