using PyTorch WARP_SHFL_DOWN macro for half support #2843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In preparation for ROCm5.6, this is required for successful compilation. Using AMD's intrinsic resulted in an "ambiguous-type" error. TLDR; some hip-header migration it seems.
This PR will require tests against ROCm5.6 once it is released and the CI is using it.
Modification
Using Pytorch's macro to handle the shfl_down intrinsic for functionality and portability.
Checklist
Before PR:
After PR: