Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Replace roipoint_pool3d op of MLU backend with mlu-ops #2875

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

ClowDragon
Copy link
Contributor

…nterface

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Delete mlu bangc kernel and replace kernel interface with mlu-ops interface

Modification

Delete mlu bangc kernel and replace kernel interface with mlu-ops interface

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
No
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@ClowDragon ClowDragon changed the title feat(roipoint_pool3d): remove bangc kernel and replace with mlu-ops i… [Refactor] roipoint_pool3d operator remove bangc kernel and replace with mlu-ops i… Jul 27, 2023
@ClowDragon ClowDragon force-pushed the jyh/fix-roipoint3d-main branch from 6cd4e62 to 39f5d22 Compare July 27, 2023 09:41
@zhouzaida zhouzaida added the MLU label Aug 3, 2023
@zhouzaida zhouzaida changed the title [Refactor] roipoint_pool3d operator remove bangc kernel and replace with mlu-ops i… [Refactor] Replace roipoint_pool3d op of MLU backend with mlu-ops Aug 28, 2023
@zhouzaida zhouzaida merged commit 8b8bf5e into open-mmlab:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants