Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lml/jit decorator #673

Merged
merged 13 commits into from
Dec 15, 2020
Merged

Lml/jit decorator #673

merged 13 commits into from
Dec 15, 2020

Conversation

lml131
Copy link
Contributor

@lml131 lml131 commented Nov 26, 2020

1、rename parrots.jit.pat as mmcv.jit
2、add tests for mmcv.jit, these test cases will pass under both pytorch and parrots environment

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #673 (f4faa28) into master (0d56211) will increase coverage by 0.15%.
The diff coverage is 86.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   64.79%   64.95%   +0.15%     
==========================================
  Files         135      136       +1     
  Lines        7835     7893      +58     
  Branches     1388     1399      +11     
==========================================
+ Hits         5077     5127      +50     
- Misses       2493     2499       +6     
- Partials      265      267       +2     
Flag Coverage Δ
unittests 64.95% <86.07%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/fileio/file_client.py 89.43% <ø> (-0.17%) ⬇️
mmcv/runner/hooks/optimizer.py 23.75% <0.00%> (-1.25%) ⬇️
mmcv/utils/env.py 56.60% <0.00%> (ø)
mmcv/utils/parrots_jit.py 81.81% <81.81%> (ø)
mmcv/cnn/bricks/activation.py 100.00% <100.00%> (ø)
mmcv/runner/dist_utils.py 51.54% <100.00%> (+0.50%) ⬆️
mmcv/utils/__init__.py 87.50% <100.00%> (+0.83%) ⬆️
mmcv/utils/config.py 88.99% <100.00%> (+0.25%) ⬆️
mmcv/version.py 92.30% <100.00%> (ø)
mmcv/video/optflow.py 97.67% <100.00%> (+0.49%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d56211...b886514. Read the comment docs.

mmcv/utils/parrots_jit.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne requested a review from hellock November 28, 2020 13:50
@ZwwWayne
Copy link
Collaborator

LGTM now, please @hellock have a check.

@hellock
Copy link
Member

hellock commented Nov 28, 2020

Task linked: CU-5brfzn MMCV add parrots JIT API

mmcv/utils/parrots_jit.py Outdated Show resolved Hide resolved
mmcv/utils/parrots_jit.py Outdated Show resolved Hide resolved
mmcv/utils/parrots_jit.py Outdated Show resolved Hide resolved
@hellock hellock merged commit 9befc39 into open-mmlab:master Dec 15, 2020
@OpenMMLab-Assistant-007
Copy link

Hi!
@lml131
First of all, we want to express our gratitude for your significant PR in the OpenMMLab project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants