Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common testing function of MM repos #743

Merged

Conversation

congee524
Copy link
Contributor

Add common testing function of MM repos

@congee524 congee524 force-pushed the add_common_testing_function_of_MM_repos branch from 24e3da3 to bd9e93d Compare December 21, 2020 09:25
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #743 (7e058f2) into master (4f0f1f9) will decrease coverage by 1.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   64.85%   63.40%   -1.46%     
==========================================
  Files         136      144       +8     
  Lines        7989     8440     +451     
  Branches     1411     1511     +100     
==========================================
+ Hits         5181     5351     +170     
- Misses       2539     2820     +281     
  Partials      269      269              
Flag Coverage Δ
unittests 63.40% <100.00%> (-1.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/__init__.py 88.23% <100.00%> (+0.73%) ⬆️
mmcv/utils/testing.py 100.00% <100.00%> (ø)
mmcv/ops/roi_align.py 60.00% <0.00%> (-1.85%) ⬇️
mmcv/tensorrt/tensorrt_utils.py 0.00% <0.00%> (ø)
mmcv/onnx/info.py 12.50% <0.00%> (ø)
mmcv/tensorrt/init_plugins.py 0.00% <0.00%> (ø)
mmcv/onnx/simplify/core.py 14.04% <0.00%> (ø)
mmcv/onnx/simplify/__init__.py 100.00% <0.00%> (ø)
mmcv/onnx/simplify/common.py 13.79% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0f1f9...7e058f2. Read the comment docs.

@congee524 congee524 force-pushed the add_common_testing_function_of_MM_repos branch from 4a8549d to 7b0d45f Compare December 21, 2020 11:05
@congee524 congee524 force-pushed the add_common_testing_function_of_MM_repos branch 2 times, most recently from e20daf3 to 13590d1 Compare December 22, 2020 01:47
add unittest for check_dict

add unittest for the function in testing
rename some function
@congee524 congee524 force-pushed the add_common_testing_function_of_MM_repos branch from 2324668 to 9fe758c Compare December 28, 2020 09:34
@congee524 congee524 force-pushed the add_common_testing_function_of_MM_repos branch from 9fe758c to 6db6f5e Compare December 28, 2020 09:41
@ZwwWayne ZwwWayne requested a review from xvjiarui January 1, 2021 15:11
@hellock
Copy link
Member

hellock commented Jan 2, 2021

Use unified naming conventions for methods with similar functionalities.

@congee524
Copy link
Contributor Author

kindly ping :p

@congee524 congee524 force-pushed the add_common_testing_function_of_MM_repos branch from 22efb59 to 8646781 Compare January 6, 2021 05:00
@ZwwWayne ZwwWayne merged commit 905c9b4 into open-mmlab:master Jan 8, 2021
@congee524 congee524 deleted the add_common_testing_function_of_MM_repos branch January 8, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants