Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest from the runtime dependencies #763

Merged
merged 4 commits into from
Dec 28, 2020

Conversation

hellock
Copy link
Member

@hellock hellock commented Dec 28, 2020

No description provided.

@hellock hellock changed the title Update the CI to avoid extra dependencies Remove pytest from the runtime dependencies Dec 28, 2020
@hellock hellock requested a review from ycxioooong December 28, 2020 03:45
Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for revision on init.py.
https://github.com/open-mmlab/mmcv/blob/master/mmcv/utils/__init__.py
del skip_no_parrots

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #763 (aa0267a) into master (5d488e4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   64.87%   64.85%   -0.03%     
==========================================
  Files         136      136              
  Lines        7994     7989       -5     
  Branches     1411     1411              
==========================================
- Hits         5186     5181       -5     
  Misses       2539     2539              
  Partials      269      269              
Flag Coverage Δ
unittests 64.85% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/__init__.py 87.50% <100.00%> (ø)
mmcv/utils/parrots_jit.py 76.47% <100.00%> (-5.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d488e4...aa0267a. Read the comment docs.

@hellock hellock merged commit c1acedc into open-mmlab:master Dec 28, 2020
@hellock hellock deleted the fix-dependency branch December 28, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants