Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: add header file for std::iota(#803) #820

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Feb 4, 2021

This PR adds header file for std::iota in PR #803.
Error message when install from source:

/mmcv/mmcv/ops/csrc/onnxruntime/cpu/nms.cpp:57:8: error: ‘iota’ i
368        std::iota(order.begin(), order.end(), 0);

@RunningLeon RunningLeon requested a review from hellock February 4, 2021 09:21
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #820 (823cd90) into master (459d728) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   62.25%   62.25%           
=======================================
  Files         144      144           
  Lines        8504     8504           
  Branches     1522     1522           
=======================================
  Hits         5294     5294           
  Misses       2945     2945           
  Partials      265      265           
Flag Coverage Δ
unittests 62.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/nms.py 34.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459d728...232b93c. Read the comment docs.

@RunningLeon RunningLeon self-assigned this Feb 4, 2021
@hellock hellock merged commit 5df759a into open-mmlab:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants