Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imshow_bboxes fails with incontiguous img #823

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

LutingWang
Copy link
Contributor

Fix #801

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #823 (57aae80) into master (4a694cc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   62.26%   62.25%   -0.01%     
==========================================
  Files         144      144              
  Lines        8506     8507       +1     
  Branches     1522     1522              
==========================================
  Hits         5296     5296              
- Misses       2945     2946       +1     
  Partials      265      265              
Flag Coverage Δ
unittests 62.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/visualization/image.py 10.76% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a694cc...842e17a. Read the comment docs.

Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @hellock pls have a look.

@hellock hellock merged commit 11b9264 into open-mmlab:master Feb 7, 2021
@LutingWang LutingWang deleted the fix_imshow_bboxes branch November 30, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imshow_bboxes does not show bboxes if img is incontiguous
4 participants