Add GELU activation function #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 62.97% 62.97% -0.01%
==========================================
Files 145 145
Lines 8686 8693 +7
Branches 1571 1572 +1
==========================================
+ Hits 5470 5474 +4
- Misses 2951 2953 +2
- Partials 265 266 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hellock
reviewed
Feb 21, 2021
mmcv/cnn/bricks/activation.py
Outdated
| from .registry import ACTIVATION_LAYERS | ||
|
|
||
| for module in [ | ||
| nn.ReLU, nn.LeakyReLU, nn.PReLU, nn.RReLU, nn.ReLU6, nn.ELU, | ||
| nn.Sigmoid, nn.Tanh | ||
| nn.Sigmoid, nn.Tanh, F.gelu | ||
| if TORCH_VERSION == 'parrots' or TORCH_VERSION <= '1.3.1' else nn.GELU | ||
| ]: | ||
| ACTIVATION_LAYERS.register_module(module=module) |
There was a problem hiding this comment.
I suggest wrapping a GELU module for PyTorch 1.3.x since F.gelu cannot be called like nn.GELU.
There was a problem hiding this comment.
Got it! Thanks a lot!
hellock
approved these changes
Feb 22, 2021
|
Also add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VisionTransformer need GELU activation function.