Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytorch2onnx failed for interpolate op with PyTorch==1.6.0(mmdet#4646) #848

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

RunningLeon
Copy link
Collaborator

Fix issue in mmdet issue 4646

This PR includes:

  1. Fix interpolate op's pytorch2onnx conversion error with PyTorch==1.6.0
  2. Add unit test of pytorch2onnx for interpolate op

@RunningLeon RunningLeon requested a review from ZwwWayne February 22, 2021 06:31
@RunningLeon RunningLeon self-assigned this Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #848 (ce4cbaa) into master (72e13e6) will increase coverage by 3.36%.
The diff coverage is 27.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   62.97%   66.34%   +3.36%     
==========================================
  Files         145      145              
  Lines        8686     8780      +94     
  Branches     1571     1597      +26     
==========================================
+ Hits         5470     5825     +355     
+ Misses       2951     2641     -310     
- Partials      265      314      +49     
Flag Coverage Δ
unittests 66.34% <27.18%> (+3.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/base_runner.py 67.82% <0.00%> (-1.82%) ⬇️
mmcv/runner/hooks/sampler_seed.py 50.00% <ø> (ø)
mmcv/tensorrt/tensorrt_utils.py 1.91% <3.22%> (+0.87%) ⬆️
mmcv/cnn/bricks/activation.py 87.50% <62.50%> (-12.50%) ⬇️
mmcv/onnx/onnx_utils/symbolic_helper.py 33.72% <72.72%> (+33.72%) ⬆️
mmcv/ops/nms.py 41.17% <75.00%> (+6.73%) ⬆️
mmcv/utils/config.py 89.85% <81.81%> (-0.27%) ⬇️
mmcv/version.py 92.30% <100.00%> (ø)
mmcv/ops/info.py 61.90% <0.00%> (+14.28%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e13e6...6e6e06e. Read the comment docs.

@hellock
Copy link
Member

hellock commented Feb 23, 2021

Unittests for onnx are not run on Github Actions.

@RunningLeon
Copy link
Collaborator Author

Unittests for onnx are not run on Github Actions.

Hi, @hellock

I believe test_onnx.py would be ran with torch+cpu.
You can click Details of build with cpu to check the results:

tests/test_ops/test_nms.py ....                                          [ 49%]
tests/test_ops/test_nms_rotated.py ss                                    [ 50%]
tests/test_ops/test_onnx.py ss.s..                                       [ 52%]

Check here for the build process.

@hellock
Copy link
Member

hellock commented Feb 23, 2021

Seems that test_onnx.py is skipped for build_cuda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants