Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the potential bug of
ConvModule
when specifying thenorm_cfg
as None.The original implementation would raise the
ConvModule' object has no attribute 'norm
when you try to callself.norm
when passingnorm_cfg
as None.I believe the original design is not reasonable, because you can find an attribute named
norm
bydir(instance)
orinstance.__dict__
, but when you access it byinstance.norm
, it will raise an error.Closes #871