Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add OneCycleLrUpdaterHook #906

Merged
merged 4 commits into from
Apr 2, 2021

Conversation

zhouzaida
Copy link
Collaborator

Related Issue: #896

@@ -398,6 +399,124 @@ def get_lr(self, runner, base_lr):
progress / (end_iter - start_iter))


@HOOKS.register_module()
class OneCycleLrUpdaterHook(LrUpdaterHook):
"""Cyclic LR Scheduler.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Cycle LR Scheduler

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #906 (d146707) into master (5f5e8e8) will decrease coverage by 1.31%.
The diff coverage is 38.18%.

❗ Current head d146707 differs from pull request most recent head 602fe1c. Consider uploading reports for the commit 602fe1c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   65.93%   64.61%   -1.32%     
==========================================
  Files         147      148       +1     
  Lines        8992     9352     +360     
  Branches     1614     1698      +84     
==========================================
+ Hits         5929     6043     +114     
- Misses       2747     2962     +215     
- Partials      316      347      +31     
Flag Coverage Δ
unittests 64.61% <38.18%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/bricks/transformer.py 0.00% <0.00%> (ø)
mmcv/runner/base_module.py 79.41% <0.00%> (ø)
mmcv/runner/hooks/momentum_updater.py 51.48% <44.21%> (-6.85%) ⬇️
mmcv/runner/hooks/lr_updater.py 57.54% <60.00%> (+0.72%) ⬆️
mmcv/onnx/symbolic.py 40.60% <75.00%> (+0.71%) ⬆️
mmcv/cnn/utils/weight_init.py 91.57% <84.00%> (-7.28%) ⬇️
mmcv/image/geometric.py 94.19% <92.00%> (-0.28%) ⬇️
mmcv/image/photometric.py 99.26% <92.85%> (-0.74%) ⬇️
mmcv/cnn/bricks/registry.py 100.00% <100.00%> (ø)
mmcv/image/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5e8e8...602fe1c. Read the comment docs.

@hellock hellock merged commit f0c43fd into open-mmlab:master Apr 2, 2021
@zhouzaida zhouzaida deleted the add_one_cycle_lr_updater_hook branch April 2, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants