Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] OneCycleLrUpdaterHook adds total_steps #929

Merged
merged 11 commits into from
Apr 10, 2021

Conversation

MeowZheng
Copy link
Collaborator

Add total_steps, the total number of steps in the cycle. Note that if a value is not provided here, it will be the max_iter of runner.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #929 (ea03982) into master (d525cfd) will increase coverage by 0.02%.
The diff coverage is 64.70%.

❗ Current head ea03982 differs from pull request most recent head b4d783c. Consider uploading reports for the commit b4d783c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   65.40%   65.43%   +0.02%     
==========================================
  Files         151      151              
  Lines        9635     9648      +13     
  Branches     1775     1780       +5     
==========================================
+ Hits         6302     6313      +11     
  Misses       2986     2986              
- Partials      347      349       +2     
Flag Coverage Δ
unittests 65.43% <64.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/runner/hooks/logger/wandb.py 68.75% <40.00%> (-6.25%) ⬇️
mmcv/runner/hooks/lr_updater.py 65.78% <75.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d525cfd...b4d783c. Read the comment docs.

@hellock hellock requested a review from zhouzaida April 8, 2021 05:09
@MeowZheng MeowZheng requested review from zhouzaida and ZwwWayne April 8, 2021 14:17
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Apr 9, 2021

lint failed.

Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Apr 9, 2021

CI failed

@hellock hellock merged commit 89efc60 into open-mmlab:master Apr 10, 2021
@MeowZheng MeowZheng deleted the onecycle branch April 12, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants