Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant self.init_cfg #959

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

jshilong
Copy link
Collaborator

Motivation

Actually init_cfg would be set in BaseModule, self.init_cg in subclass is redundant.

##BC-breaking
None

@jshilong jshilong requested a review from nbei April 16, 2021 15:03
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #959 (5a5fe69) into master (ae41150) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5a5fe69 differs from pull request most recent head 46c4e05. Consider uploading reports for the commit 46c4e05 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   65.64%   65.66%   +0.02%     
==========================================
  Files         149      149              
  Lines        9455     9452       -3     
  Branches     1722     1722              
==========================================
  Hits         6207     6207              
+ Misses       2928     2925       -3     
  Partials      320      320              
Flag Coverage Δ
unittests 65.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/bricks/transformer.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae41150...46c4e05. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants