Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load hook_msgs when resume checkpoint #962

Merged
merged 8 commits into from
May 13, 2021
Merged

Conversation

dreamerlin
Copy link
Contributor

This PR is to load hook_msgs meta information saved in checkpoint which helps to store the best related information for evaluation

mmcv/runner/base_runner.py Outdated Show resolved Hide resolved
@hellock hellock requested a review from xvjiarui April 17, 2021 11:28
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #962 (a2f3406) into master (5504b5f) will decrease coverage by 1.03%.
The diff coverage is 33.76%.

❗ Current head a2f3406 differs from pull request most recent head 3cedea6. Consider uploading reports for the commit 3cedea6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   65.66%   64.63%   -1.04%     
==========================================
  Files         149      152       +3     
  Lines        9452     9822     +370     
  Branches     1722     1785      +63     
==========================================
+ Hits         6207     6348     +141     
- Misses       2925     3144     +219     
- Partials      320      330      +10     
Flag Coverage Δ
unittests 64.63% <33.76%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/bricks/transformer.py 0.00% <0.00%> (ø)
mmcv/ops/box_iou_rotated.py 100.00% <ø> (ø)
mmcv/ops/fused_bias_leakyrelu.py 30.90% <0.00%> (ø)
mmcv/ops/nms.py 45.65% <ø> (ø)
mmcv/ops/upfirdn2d.py 15.29% <0.00%> (ø)
mmcv/parallel/data_parallel.py 32.35% <0.00%> (ø)
mmcv/utils/__init__.py 88.23% <ø> (ø)
mmcv/utils/ext_loader.py 52.00% <ø> (ø)
mmcv/runner/hooks/optimizer.py 17.74% <10.20%> (-6.01%) ⬇️
mmcv/runner/hooks/profiler.py 14.10% <14.10%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5504b5f...3cedea6. Read the comment docs.

@dreamerlin dreamerlin requested a review from zhouzaida April 19, 2021 07:12
@ZwwWayne ZwwWayne requested a review from zhouzaida May 1, 2021 08:42
@ZwwWayne ZwwWayne mentioned this pull request May 1, 2021
13 tasks
@ZwwWayne ZwwWayne merged commit 4c2b05f into open-mmlab:master May 13, 2021
@zhouzaida zhouzaida mentioned this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants