Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mmcv installation #149

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

RunningLeon
Copy link
Collaborator

Motivation

Update mmcv installation as in mmtracking PR

Modification

Update mmcv installation in CI and documents.

BC-breaking (Optional)

None

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #149 (cfd4c06) into master (a2b3ab3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   66.20%   66.20%           
=======================================
  Files         175      175           
  Lines        5962     5962           
  Branches      937      937           
=======================================
  Hits         3947     3947           
  Misses       1731     1731           
  Partials      284      284           
Flag Coverage Δ
unittests 66.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b3ab3...cfd4c06. Read the comment docs.

Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make the version limitation to toch or mmcv in requirements?

@RunningLeon
Copy link
Collaborator Author

Shall we make the version limitation to toch or mmcv in requirements?

Not necessary. mmcv-full is installed outside requirements.txt

Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 3eff20d into open-mmlab:master Feb 11, 2022
hanrui1sensetime pushed a commit to hanrui1sensetime/mmdeploy that referenced this pull request Nov 25, 2022
* update

* update

* update

* update

* update

* add docstr

* fix comments

* update
hanrui1sensetime pushed a commit to hanrui1sensetime/mmdeploy that referenced this pull request Nov 25, 2022
* add yolov5 voc training

* format code

* [Feature] Support YOLOv7 inference (open-mmlab#149)

* update

* update

* update

* update

* update

* add docstr

* fix comments

* update

* add video of featmap vis demo (open-mmlab#169)

* [Enhance] YOLOv6 model convert (open-mmlab#165)

* add yolov5 voc training

* fix bug

* fix bug

* fix yolov6 model convert

* update yolov5 modelconvert

* rollback yolov5 model convert

* [Feature] Support VOC Dataset in YOLOv5 (open-mmlab#134)

* add yolov5 voc training

* fix mosaic bug

* fix mosaic bug and temp config

* fix mosaic bug

* update config

* support training on voc dataset

* format code

* format code

* Optimize Code. Change `RandomTransform` to `OneOf`

* Change `OneOf` to `mmcv.RandomChoice`

* fix yolov5coco dataset

* fix yolov5coco dataset

* fix bug, format code

* format config

* format code

* add yolov5 voc training

* rebase

* fix mosaic bug

* update config

* support training on voc dataset

* format code

* format code

* Optimize Code. Change `RandomTransform` to `OneOf`

* Change `OneOf` to `mmcv.RandomChoice`

* fix yolov5coco dataset

* fix yolov5coco dataset

* fix bug, format code

* format code

* add yolov5 voc training

* fix mosaic bug and temp config

* fix mosaic bug

* update config

* support training on voc dataset

* format code

* format code

* Optimize Code. Change `RandomTransform` to `OneOf`

* Change `OneOf` to `mmcv.RandomChoice`

* fix yolov5coco dataset

* fix yolov5coco dataset

* fix bug, format code

* format code

* add yolov5 voc training

* rebase

* fix mosaic bug

* update config

* support training on voc dataset

* format code

* format code

* Optimize Code. Change `RandomTransform` to `OneOf`

* Change `OneOf` to `mmcv.RandomChoice`

* fix yolov5coco dataset

* fix yolov5coco dataset

* fix bug, format code

* format code

* format code

* fix lint

* add unittest

* add auto loss_weight

* add doc; add model log url

* add doc; add model log url

* add doc; add model log url

* add neck vis docstr

* add neck vis docstr

* add backbone model structure diagram

* fix readthedocs.txt

* fix doc vis

* fix vis

* fix vis

* fix vis

* fix vis

Co-authored-by: Haian Huang(深度眸) <huanghaian@pjlab.org.cn>
@RunningLeon RunningLeon deleted the update_mmcv_install branch April 6, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants