[Fix] fix ncnn #187
Merged
[Fix] fix ncnn #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 66.98% 66.98%
=======================================
Files 189 189
Lines 6176 6176
Branches 955 955
=======================================
Hits 4137 4137
Misses 1746 1746
Partials 293 293
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lvhan028
reviewed
Feb 28, 2022
| set(_NCNN_EXT_DIR ${CMAKE_SOURCE_DIR}/mmdeploy/backend/ncnn) | ||
| set_target_properties(ncnn_ext PROPERTIES | ||
| LIBRARY_OUTPUT_DIRECTORY ${_NCNN_EXT_DIR} | ||
| LIBRARY_OUTPUT_DIRECTORY_DEBUG ${_NCNN_EXT_DIR} |
There was a problem hiding this comment.
Are both LIBRARY_OUTPUT_DIRECTORY_DEBUG and LIBRARY_OUTPUT_DIRECTORY_RELEASE properties necessary?
There was a problem hiding this comment.
On MSVC, the path to the target will contain "Debug" or "Release" otherwise.
hanrui1sensetime
pushed a commit
to hanrui1sensetime/mmdeploy
that referenced
this pull request
Nov 25, 2022
* remove albu version limit * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
ncnn was not taken into consideration in #106, this PR tries to bring it back.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist